Templates modal implementation #1909
Conversation
|
|
Add a gap horizontally between select and filter input. Make the two have equal height. |
|
Hi @thecalcc, the design is not OK. You have the HTML code here: https://ui-framework.superdesk.org/#/playgrounds/react/test-ground (click on the "PLANNING TEMPLATES" button at the top). No need for improvisation. |
|
@fritzSF we agreed we'll be removing dropdown component from the framework, so I asked Konstantin not to use it in new code. We'll try to make it looks the same. |
client/components/PlanningTemplatesModal/PlanningTemplatesModal.tsx
Outdated
Show resolved
Hide resolved
| const activeCalendarName = this.props.calendars | ||
| .find((cal) => cal.qcode === this.state.activeCalendarFilter)?.name; | ||
| const dropdownLabel = this.state.activeCalendarFilter | ||
| ? `${gettext('Calendar')}: ${activeCalendarName}` |
There was a problem hiding this comment.
gettext doesn't work well with string literals, better use:
gettext('Calendar: {{activeCalendarName}}', {activeCalendarName});
|
@MarkLark86 @devketanpro can you please check the failing test on your side locally? I can't get it to run properly thus can't fix it. From my POV the input hasn't changed so it should be working correctly, but please check it if you have the e2e setup working correctly locally. |
SDBELGA-764